-
Notifications
You must be signed in to change notification settings - Fork 107
Bump UI frameworks (Docusaurus, MDX, React) #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add plugin for unwrapping jsx mdx
Deploy preview ready for 2722! |
Deploy preview ready for 2722! |
rick-bt
approved these changes
Apr 5, 2024
Deploy preview ready for 2722! |
Deploy preview ready for 2722! |
Deploy preview ready for 2722! |
discombobulateme
approved these changes
May 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps the various UI frameworks used in sauce-docs, including Docusaurus, MDX to v3, React to v18, etc.
Motivation and Context
Our deps were pretty out of date and lacked features for dynamic variables & partials that newer MDX versions support.
Unfortunately, MDX2 and up is a breaking change.
Included in the PR are fixes for the following:
{var}
is now parsed as a JS variable, and needs to be escaped like\{var}
to have it render as they previously did)<p>
tags whenever there is a newline after a component. I've included a plugin here to revert this behavior as it would break a lot of styles on the docs site across many pagesTypes of Changes