Skip to content

IRIS-849-csharp-fullpage #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2024
Merged

IRIS-849-csharp-fullpage #2718

merged 6 commits into from
Apr 10, 2024

Conversation

paweltomaszewskisaucelabs
Copy link
Contributor

Description

Add c# fullpage screenshot docs

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from 5dbdacd

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from 96d0ae3

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from fe09797

konraddysput
konraddysput approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@konraddysput konraddysput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please wait for Felix approval to land it?

docs/visual-testing/integrations/csharp.md
@@ -333,6 +334,46 @@ VisualClient = VisualClient.Create(Driver, Region.UsWest1, sauceUsername, sauceA
VisualClient.CaptureDom = true;
```

### Full page screenshots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to enable this option for every VisualCheck via Client options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but we have task to do it
https://saucedev.atlassian.net/browse/IRIS-892

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from 7e0f6ac

FriggaHel
FriggaHel reviewed Apr 9, 2024
View reviewed changes
docs/visual-testing/integrations/java.md Outdated
Additionally, you have the option to configure full page settings using the `FullPageConfig` option.

:::note
It's recommended to use the `HideAfterFirstScroll` option for fixed or sticky position elements such as sticky headers or consent banners.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct for java ? Isn't it expected to use Builder ?

Casing looks off too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/visual-testing/integrations/java.md Outdated
Comment on lines 343 to 344
- `DelayAfterScrollMs`: Delay in ms after scrolling and before taking screenshots. The default value is 0. We recommend using this option for lazy loading content.
- `HideAfterFirstScroll`: Hide elements on the page after first scroll (uses css selectors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/visual-testing/integrations/java.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for changes to that file ? Seems like FullPageDescription was doing exactly this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to provide specific description for java then yes we need to change it

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from a3180b8

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2718!
https://docs.dev.saucelabs.net
built from e52ae3b

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs merged commit 4da02e1 into main Apr 10, 2024
7 checks passed
@paweltomaszewskisaucelabs paweltomaszewskisaucelabs deleted the IRIS-849-csharp-fullpage branch April 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konraddysput konraddysput konraddysput approved these changes

@FriggaHel FriggaHel FriggaHel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paweltomaszewskisaucelabs @konraddysput @FriggaHel