-
Notifications
You must be signed in to change notification settings - Fork 38
added SchemaConverter interface for controlling Schema generation #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, follow the guidelines for contributions: https://github.com/sashirestela/simple-openai/blob/main/CONTRIBUTING.md
added SchemaConverter interface for controlling Schema generation from classes
@sashirestela fixed formatting , anything else ? |
@asafbennatan The build has failed. Take a look at: https://github.com/sashirestela/simple-openai/actions/runs/10005920792/job/27698385663?pr=160 |
src/main/java/io/github/sashirestela/openai/common/function/FunctionDef.java
Show resolved
Hide resolved
@sashirestela done , please review |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
============================================
+ Coverage 89.62% 89.71% +0.08%
- Complexity 697 700 +3
============================================
Files 101 102 +1
Lines 1465 1468 +3
Branches 31 31
============================================
+ Hits 1313 1317 +4
+ Misses 107 106 -1
Partials 45 45 ☔ View full report in Codecov by Sentry. |
solves #159
1.added
SchemaConverter
interface for controlling Schema generation2.added
DefaultSchemaConverter
for running the default (same logic that we had before inJsonSchemaUtil
) - note this also improves performance as previously schema creator was created per serialization3.
JsonSchemaUtil
is not really necessary anymore but kept to be compatible;