Make Boost regex a private dependency #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not include boost/regex.hpp in the main api file (TextEditor.h), so that users do not need to add vendor/boost/regex to their include path - Only TextEditor.cpp will include boost/regex.hpp (private dependency) - We use a partial pImpl: RegexList is declared inside TextEditor.h, and implemented inside TextEditor.cpp - We use a shared_ptr<RegexList> instead of unique_ptr , because we want to keep TextEditor copyable (otherwise, this would break the API for existing users)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR brings two modifications:
use "%zu" in printf specifiers for vector sizes
make boost/regex a private dependency
(i.e. it can be included in TextEditor.cpp, but not in TextEditor.h which is part of the API).
The reason for this is to avoid that users would need to add vendor/boost/regex to their include path (when it is only used by TextEditor.cpp).
Cheers,