Skip to content

autofill correction form #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drdhaval2785 opened this issue Dec 17, 2020 · 4 comments
Open

autofill correction form #26

drdhaval2785 opened this issue Dec 17, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@drdhaval2785
Copy link
Contributor

https://www.sanskrit-lexicon.uni-koeln.de/scans/csl-corrections/app/correction_form.php?dict=MW is fine as of now.
sanskrit-lexicon/COLOGNE#220 (comment) suggested that there should be smart way of submitting errors.

This is how I see the enhancement steps.

Current scenario

The correction_form.php takes the following information from the user.

  1. Which Dictionary? *
  2. Which ID? *
  3. Which Headword? *
  4. What is the typo?
  5. What is the correction?
  6. What kind of error?
  7. Your Name or e-mail ID?

Suggested scenario

  1. Dropdown for dictionary
  2. ID is the step which user has to key in manually
  3. Can be autopopulated from mw.txt file
  4. Can be autopopulated from mw.txt file
  5. Can be autopopulated from mw.txt file (Initially it will be identical to point 5. The user can correct the entry as he thinks fit)
  6. Manual
  7. Manual

Ajax

When the user has written ID in point 2, there should be an ajax call to the server for getting data for the points 3-6.

@drdhaval2785 drdhaval2785 added the enhancement New feature or request label Dec 17, 2020
@funderburkjim
Copy link
Contributor

Personally, I find the current correction submission system completely
satisfactory.

Some time ago, Marcis promoted an alternate system, and a coder
he knew provided much of the code.
This is still a part of the simple-search display. Here's how it works:

First go to https://www.sanskrit-lexicon.uni-koeln.de/simple/.

Get a display of any word in any dictionary.
Then, select some text for a potential correction:
Then, click Ctrl-Enter.
Here's what you see:
image

Then you can fill in the correction field, and click 'Send'. This should
send a correction record to the normal place (in csl-corrections at Cologne)

As a test, I submitted a correction. Discovered that it
goes to the OLD place on Cologne server.
If we continue to have this code, we need to change the target
to the appropriate place on Cologne server.

In practice, this feature has never been used after it was developed.
Possibly because no user (but Marcis and me) even know how to
use it.

If you want to develop another method along the lines you mention,
fine with me.

@funderburkjim
Copy link
Contributor

@SergeA

  1. I understood you to say that the simple-search display does not work for you in
    Chrome or Opera Browsers, but that the display does work for you in Firefox Browser. Agree?
  2. If simple search display does work in some browser, what about the
    'hidden' corrections entry form as described above.
  • Does it work ?
  • Is it helpful ?

@gasyoun
Copy link
Member

gasyoun commented Dec 27, 2020

Instead the link to the outdated wording "Corrections", I ask to replace it with:

  1. "Found an error?"

or
404

  1. press “Ctrl + Enter” to to submit a correction

After pressing on these words a tooltip shows up:

If you want to correct just a few entries, please

  1. select a word to be corrected and
  2. press “Ctrl + Enter” to to submit a correction
  3. fill what it is to be raplaced with or comment
  4. write your email for later identification

If you have a batch of corrections, please e-mail us.

fire

We should add a screenshot in the tooltip and maybe even use icons for the buttons.

https://visualpharm.com/free-icons/ctrl-595b40b85ba036ed117dce45 Ctrl Icon
https://visualpharm.com/free-icons/enter%20key-595b40b85ba036ed117dd101 Enter Key Icon

@gasyoun
Copy link
Member

gasyoun commented Dec 31, 2020

agni

May come, after @funderburkjim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants