Skip to content

Y24-190 - convert search qcable to API v2 #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2025

Conversation

StephenHulme
Copy link
Contributor

Closes #2171

Changes proposed in this pull request

  • Convert search qcable api call to API v2

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the base branch from develop to Y24-190-milestone-4 April 3, 2025 14:36
@StephenHulme StephenHulme self-assigned this Apr 14, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (966abfd) to head (3a0719e).
Report is 11 commits behind head on Y24-190-milestone-4.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           Y24-190-milestone-4    #2304      +/-   ##
=======================================================
- Coverage                81.27%   81.26%   -0.01%     
=======================================================
  Files                      482      482              
  Lines                    18531    18533       +2     
  Branches                   278      278              
=======================================================
  Hits                     15061    15061              
- Misses                    3468     3470       +2     
  Partials                     2        2              
Flag Coverage Δ
javascript 74.76% <ø> (ø)
pull_request 81.26% <100.00%> (-0.01%) ⬇️
push 81.26% <100.00%> (-0.01%) ⬇️
ruby 91.78% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme requested a review from harrietc52 April 16, 2025 13:50
@StephenHulme StephenHulme merged commit 78eeb75 into Y24-190-milestone-4 Apr 16, 2025
16 checks passed
@StephenHulme StephenHulme deleted the y24-190-convert-search-qcable-to-v2 branch April 16, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-190-4: API V2 Milestone 4
2 participants