-
Notifications
You must be signed in to change notification settings - Fork 0
Mobile responsive header (and footer) #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed basic layout for a mobile header
Changed basic layout for a mobile header
…nto mobile-header
Reduced font size of footer at small screen sizes
Created the mobile menu for the header.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RishikeshNK
approved these changes
Apr 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blind approve
banushi-a
approved these changes
Apr 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a mobile-responsive header and footer. Added a nav menu for the mobile header. Also moved header components to a separate header folder.
Motivation and Context
Mobile responsiveness was not in the header and footer before.
Closes #204
How has this been tested?
Resized the window in all pages and clicked the mobile nav button.
Screenshots (if appropriate):
Types of changes
pnpm db:generate
and verified generated SQL migration files inpackages/db/drizzle
Checklist: