Skip to content

Location search fix #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2025
Merged

Location search fix #206

merged 4 commits into from
Apr 13, 2025

Conversation

gpalmer27
Copy link
Contributor

Description

Abstracted location combobox and fixed bug with location box after switching between different parts of the website.

Motivation and Context

No more bug during cooper live demo!

Closes #[ticket]

How has this been tested?

Clicked through the website over and over again

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database migration
    • Ran pnpm db:generate and verified generated SQL migration files in packages/db/drizzle

Checklist:

  • [ x] My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • [ x] I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Apr 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 0:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Apr 13, 2025 0:57am
cooper-docs ⬜️ Skipped (Inspect) Apr 13, 2025 0:57am

@gpalmer27 gpalmer27 requested a review from banushi-a April 12, 2025 21:40
@vercel vercel bot temporarily deployed to Preview – cooper-auth April 13, 2025 00:56 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs April 13, 2025 00:56 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leggo

@gpalmer27 gpalmer27 merged commit b91e883 into main Apr 13, 2025
9 checks passed
@gpalmer27 gpalmer27 deleted the location-search-fix branch April 13, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants