-
Notifications
You must be signed in to change notification settings - Fork 0
Begin Reworking New Review Button #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gpalmer27
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to the New Review Dialog and Form Style Updates (RIP the swamp green and bright blue combo 🙏🏻 )
Motivation and Context
With the additions to the companies table and general changes in how users interact with the app, we need to allow for more flexibility in users going to create a new review.
The original new review button was meant to be temporary for the first showcase, and so is this. Next semester, designers should come up with a way to allow users to leave a review for
For now, I have put the first two into one tab and the third one into another tab.
I also changed
How has this been tested?
In the process of manually testing the frontend. Backend tests 🔜
Screenshots:
If you have already created too many roles (4), you won't be able to create a new company.
Types of changes
Checklist: