Skip to content

Begin Reworking New Review Button #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 10, 2025
Merged

Begin Reworking New Review Button #197

merged 12 commits into from
Apr 10, 2025

Conversation

banushi-a
Copy link
Contributor

@banushi-a banushi-a commented Apr 7, 2025

Description

Improvements to the New Review Dialog and Form Style Updates (RIP the swamp green and bright blue combo 🙏🏻 )

Motivation and Context

With the additions to the companies table and general changes in how users interact with the app, we need to allow for more flexibility in users going to create a new review.

The original new review button was meant to be temporary for the first showcase, and so is this. Next semester, designers should come up with a way to allow users to leave a review for

  • An existing company and existing role
  • An existing company and new role
  • A new company and new role

For now, I have put the first two into one tab and the third one into another tab.

I also changed

  • Overflow scroll -> auto
  • The New Review button at the bottom of the Roles page would still appear when not logged in / created too many reviews

How has this been tested?

In the process of manually testing the frontend. Backend tests 🔜

Screenshots:

Screenshot 2025-04-07 at 4 39 48 PM

If you have already created too many roles (4), you won't be able to create a new company.

Screenshot 2025-04-07 at 11 44 08 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 7:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Apr 10, 2025 7:05pm
cooper-docs ⬜️ Skipped (Inspect) Apr 10, 2025 7:05pm

@vercel vercel bot temporarily deployed to Preview – cooper-auth April 7, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs April 7, 2025 20:40 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs April 10, 2025 01:22 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth April 10, 2025 01:22 Inactive
@banushi-a banushi-a marked this pull request as ready for review April 10, 2025 01:33
@tracyyh
Copy link
Contributor

tracyyh commented Apr 10, 2025

Screenshot 2025-04-09 at 11 56 31 PM

am i supposed to be seeing that i already created the maximum number of roles

@banushi-a
Copy link
Contributor Author

Screenshot 2025-04-09 at 11 56 31 PM am i supposed to be seeing that i already created the maximum number of roles

in the final week of my math degree and I swapped < with >

Copy link
Contributor

@gpalmer27 gpalmer27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banushi-a banushi-a changed the title [WIP] Begin Reworking New Review Button Begin Reworking New Review Button Apr 10, 2025
@vercel vercel bot temporarily deployed to Preview – cooper-docs April 10, 2025 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth April 10, 2025 19:04 Inactive
@banushi-a banushi-a merged commit 94034c0 into main Apr 10, 2025
9 checks passed
@banushi-a banushi-a deleted the NewReviewUpgrade branch April 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants