Skip to content

Restore ReferenceSequenceFileFactory deleted in previous commit. #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

cmnbroad
Copy link
Collaborator

No description provided.

return new FastaSequenceFile(path, truncateNamesAtWhitespace);
}
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can just delegate to the new method.

Copy link
Collaborator Author

@cmnbroad cmnbroad Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Well, I restored the old method and changed the new one to delegate to the old one.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. It's a bit strange that only the 4 argument version supports bundles, but we can change that if we want to later.

@lbergelson lbergelson merged commit 6332941 into master Apr 22, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants