Skip to content

fixes to shell script #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

fixes to shell script #5

merged 1 commit into from
Aug 30, 2021

Conversation

toffaletti
Copy link

  • fix typo extensionPath -> extension_path
  • use more portable method for getting extension_path
  • fix shellcheck warnings about quoting
  • optimization: check for exe before trying to build or download it

I got this on an M1 (arm64) Mac.

% gh extension install samcoe/gh-repo-explore
% gh repo-explore samcoe/gh-repo-explore
go: go.mod file not found in current directory or any parent directory; see 'go help modules'

It is working now with these changes.

fixes to shell script
8548bc2 
- fix typo extensionPath -> extension_path
- use more portable method for getting extension_path
- fix shellcheck warnings about quoting
- optimization: check for exe before trying to build or download it
@toffaletti toffaletti marked this pull request as ready for review August 29, 2021 08:32
samcoe
samcoe approved these changes Aug 30, 2021
View reviewed changes
Copy link
Owner

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

@samcoe samcoe merged commit 63500ad into samcoe:trunk Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toffaletti @samcoe