Add ElementsMatch, ElementsMatchBy #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 94.27% 94.39% +0.11%
==========================================
Files 18 18
Lines 3178 3246 +68
==========================================
+ Hits 2996 3064 +68
Misses 170 170
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm actually not sure If we should count the elements. So is done in testify package: ElementsMatch. That's the intent - to have the same familiar semantics. Though personally I don't find this counting really helpful. |
oswaldom-code
pushed a commit
to oswaldom-code/lo
that referenced
this pull request
Apr 28, 2025
* Add ElementsMatch, ElementsMatchBy * Update intersect.go * Update README.md --------- Co-authored-by: Samuel Berthe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #586