Skip to content

chore: only deploy proxy on main #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

Mkassabov
Copy link
Collaborator

No description provided.

@Mkassabov Mkassabov self-assigned this Jul 8, 2025
@Mkassabov Mkassabov added this to alchemy Jul 8, 2025
@Mkassabov Mkassabov moved this to Ready in alchemy Jul 8, 2025
Copy link

pkg-pr-new bot commented Jul 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/sam-goodwin/alchemy@603

commit: d9d171b

Copy link

github-actions bot commented Jul 8, 2025

🚀 Website Preview Deployed

Your website preview is ready!

Preview URL: https://1c7bf568-alchemy-website.alchemy-run.workers.dev

This preview was built from commit 850d483


🤖 This comment will be updated automatically when you push new commits to this PR.

@sam-goodwin sam-goodwin changed the title fix(alchemy-web): only deploy proxy on main chore: only deploy proxy on main Jul 8, 2025
Comment on lines 38 to 43
name: "alchemy-website",
name: `${app.name}-${app.stage}-website`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should change this right now because we are already deployed. Although this is a great use-case that should be allowed - "rename worker".

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude revert thos

Copy link
Contributor

@claude claude bot Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude finished @sam-goodwin's task —— View job


Todo List:

  • Read the current state of the changed files
  • Identify what changes need to be reverted around line 43 of alchemy-web/alchemy.run.ts
  • Revert the specified changes
  • Commit the reverted changes to the PR branch

Changes Reverted:

I successfully reverted the changes in alchemy-web/alchemy.run.ts:

  • Line 35: Reverted name: \${app.name}-${app.stage}-posthog-proxy`back toname: "alchemy-posthog-proxy"`
  • Line 43: Reverted name: \${app.name}-${app.stage}-website`back toname: "alchemy-website"`

The dynamic naming changes have been reverted to avoid conflicts with already deployed resources. The commit has been pushed to the PR branch.

Revert dynamic naming changes to avoid conflicts with already deployed resources.

Co-authored-by: sam <[email protected]>
@sam-goodwin sam-goodwin merged commit c4d7a9e into main Jul 8, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in alchemy Jul 8, 2025
@sam-goodwin sam-goodwin deleted the mkassabov/alchemy-web-prod-only-proxy branch July 8, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants