-
Notifications
You must be signed in to change notification settings - Fork 52
feat(dev): inspector-proxy and worker logging improvements #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Mkassabov
wants to merge
16
commits into
main
Choose a base branch
from
mkassabov/better-dev-worker-logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+537
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
3 tasks
🚀 Website Preview DeployedYour website preview is ready! Preview URL: This preview was built from commit 524be3c 🤖 This comment will be updated automatically when you push new commits to this PR. |
🚀 Website Preview DeployedYour website preview is ready! Preview URL: https://b3902c1f-alchemy-website.alchemy-run.workers.dev This preview was built from commit 20b7527 🤖 This comment will be updated automatically when you push new commits to this PR. |
5093998
to
2ba7120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
inspect.localhost:<port>
for any worker running onlocalhost:<port>
. These devtools will autoconnect to the worker.logToConsole
dev option for workers to allow hiding logs from terminal (defaults to true)Currently soft-blocked by a miniflare bug.
FIXED; WAITING FOR NEXT MINIFLARE RELEASE
see Miniflare PR: 9784
When we add new workers to miniflare via
setOptions
an inspector proxy ins't started for that worker.There does seem to be a way to get all of the proxies, but its not reliable.