Use Docker API for managing docker resources #446
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
reviewed
Jun 22, 2025
|
|
||
| export type NetworkProps = Required<Pick<Network, "Name">>; | ||
|
|
||
| export const Network = Resource( |
There was a problem hiding this comment.
Good to provide "@example" snippets. Claude does a good job at this
alchemy/src/docker/api/network.ts
Outdated
Comment on lines
21
to
30
| try { | ||
| await docker.network({ id: props.Name }).remove(); | ||
| } catch { | ||
| } finally { | ||
| try { | ||
| await docker.network({ id: props.Name }).inspect(); | ||
| } catch {} | ||
| } | ||
| return this.destroy(); |
There was a problem hiding this comment.
Are you sure you want to swallow errors
sam-goodwin
reviewed
Jun 22, 2025
scripts/generate-docker-types.ts
Outdated
Comment on lines
6
to
53
| const contractUrl = | ||
| "https://docs.docker.com/reference/api/engine/version/v1.50.yaml"; | ||
|
|
||
| const contract = await fetch( | ||
| `https://converter.swagger.io/api/convert?url=${contractUrl}`, | ||
| ).then((res) => res.json()); | ||
|
|
||
| const nodes = await run(contract); | ||
| await Bun.write("alchemy/src/docker/api/types.ts", astToString(nodes)); |
sam-goodwin
reviewed
Jun 22, 2025
alchemy/src/docker/api/api.ts
Outdated
Comment on lines
61
to
64
| const GET = async < | ||
| T extends ClientPathsWithMethod<typeof client, "get">, | ||
| Init extends MaybeOptionalInit<paths[T], "get">, | ||
| >( | ||
| path: T, | ||
| ...init: InitParam<Init> | ||
| ): Promise<MethodResponse<typeof client, "get", T>> => { | ||
| // @ts-ignore: dyncamically inferred on usage | ||
| const { data, error, response } = await client.GET(path, ...init); | ||
|
|
||
| if (error) { | ||
| throw new Error( | ||
| `Failed to GET ${path}: ${response?.status} ${response?.statusText}: ${JSON.stringify(error, null, 2)}`, | ||
| ); | ||
| } | ||
|
|
||
| return data as NonNullable<MethodResponse<typeof client, "get", T>>; |
sam-goodwin
reviewed
Jun 22, 2025
alchemy/src/docker/api/api.ts
Outdated
|
|
||
| return { | ||
| containers: {}, | ||
| network: (nameOrId: PickPathParam<"/networks/{id}", "get", "id">) => ({ |
There was a problem hiding this comment.
Better to return methods outside of the resource lifecycle handler because functions cannot be serialized.
When a resource is skipped, we don't invoke your function and instead return the persisted state data.
A wrapper function can then implement methods like network that use the data
|
@sam-goodwin sorry, I am just getting started, code is not final, will look into generating docs later, first implementing the api client. |
added 3 commits
June 29, 2025 04:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.