-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fixes AzureRM create_object_model util #56379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get some tests added here? and can you create an issue with details of the issue and tie it to this PR, to make it easier for others running into the issue to see it.
@Ch3LL test case added. This issue was actually something that we ran into in Idem, but also could apply to Salt... we just don't have any concrete errors to report. |
Merge conflicts need to be resolved. |
What does this PR do?
This PR fixes the Microsoft Azure Resource Manager create_object_model util. Currently, the util is not properly building some object models. The issue is caused by the util improperly handling the existence of parameters because it does not account for the existence of parameters that are set as Boolean values (specially False).
What issues does this PR fix or reference?
N/A
Previous Behavior
Object models with parameters that may have contained Boolean values (specially False) were being built improperly.
New Behavior
Object models with parameters that may contain Boolean values (specially False) are being built properly.
Tests written?
No
Commits signed with GPG?
Yes