Skip to content

fix coverage script #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

royra
Copy link

@royra royra commented Mar 1, 2020

  • run 'yarn fix-coverage-thresholds' to fix the tresholds on the current numbers
  • CircleCI job to fix the thresholds weekly

@royra royra requested a review from a team March 1, 2020 17:45
Roy Razon added 4 commits March 1, 2020 23:24
- run 'yarn fix-coverage-thresholds' to fix the tresholds on the current numbers
- CircleCI job to fix the thresholds weekly
@royra royra force-pushed the fix-coverage-script branch from 26140c4 to 2fe3bf4 Compare March 1, 2020 21:31
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #755 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #755     +/-   ##
=========================================
- Coverage   89.38%   89.29%   -0.1%     
=========================================
  Files         195      195             
  Lines        8715     8667     -48     
  Branches     1580     1562     -18     
=========================================
- Hits         7790     7739     -51     
- Misses        925      928      +3
Flag Coverage Δ
#unit_test 89.29% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
packages/adapter-api/src/values.ts 36.36% <0%> (-18.19%) ⬇️
packages/adapter-api/src/utils.ts 72.93% <0%> (-4.73%) ⬇️
packages/adapter-api/src/elements.ts 86.79% <0%> (-4.72%) ⬇️
...salesforce-adapter/src/transformers/transformer.ts 96.3% <0%> (-0.23%) ⬇️
...esforce-adapter/src/filters/instance_references.ts 97.56% <0%> (-0.06%) ⬇️
.../hubspot-adapter/src/filters/instance_transform.ts 90% <0%> (ø) ⬆️
...e/src/core/plan/dependency/reference_dependency.ts 100% <0%> (ø) ⬆️
packages/adapter-api/src/builtins.ts 100% <0%> (ø) ⬆️
...es/salesforce-adapter/src/filters/convert_types.ts 100% <0%> (ø) ⬆️
...es/hubspot-adapter/src/transformers/transformer.ts 97.77% <0%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428e6a4...2fe3bf4. Read the comment docs.

@royra royra force-pushed the fix-coverage-script branch from a7a0bb5 to 858a4a7 Compare March 1, 2020 21:51
@royra
Copy link
Author

royra commented Mar 5, 2020

Closing while waiting for Jest PR.

@royra royra closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant