Skip to content

Add handlebars-helpers with tests and configuration #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JannikZed
Copy link
Contributor

@JannikZed JannikZed commented Apr 10, 2025

Scope of the PR

adding the handelbars-helpers plugin, similar to the SMTP app to the products feed app

Related issues

closes #1840

Checklist

@JannikZed JannikZed requested a review from a team as a code owner April 10, 2025 14:36
Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: c173764

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-products-feed Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 10, 2025

@JannikZed is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 25.46%. Comparing base (002cbeb) to head (c173764).

Files with missing lines Patch % Lines
apps/products-feed/src/pages/configuration.tsx 0.00% 12 Missing ⚠️
apps/products-feed/next.config.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
- Coverage   25.46%   25.46%   -0.01%     
==========================================
  Files         751      751              
  Lines       53114    53132      +18     
  Branches     1812     1812              
==========================================
+ Hits        13526    13528       +2     
- Misses      39231    39247      +16     
  Partials      357      357              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-stripe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 5:46am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Product Feed: Include the handlebars helper
2 participants