Skip to content

SAK-30439 switch to libsass for morpheus #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Conversation

ern
Copy link
Contributor

@ern ern commented Mar 2, 2016

Removed ruby sass and compass switched to libsass which is much faster.

Re created all the mixins we were using in compass.

There may still be some small issues here and there but we should just create new jira's for those.

@ern ern changed the title SAK-30439 switch to libsass SAK-30439 switch to libsass for morpheus Mar 3, 2016
@ern ern added the sakai-11 label Mar 3, 2016
@SedueRey
Copy link
Contributor

SedueRey commented Mar 3, 2016

I'm going to test this if it has side-effects.

@juanjmerono
Copy link
Contributor

I was not able to compile with this new libsass at all. The mvn clean install just freezes here and never ends (the same behavior in travis) 😞

[INFO] morpheus.plugins.min.js (5451b)
[INFO] nb warnings: 79, nb errors: 0
[INFO]
[INFO] --- libsass-maven-plugin:0.2.2-libsass_3.3.3:compile (default) @ library
---

@SedueRey
Copy link
Contributor

SedueRey commented Mar 3, 2016

I'm very afraid of this changes right now that we are trying to fix all problems related to morpheus to release 11

@ern
Copy link
Contributor Author

ern commented Mar 3, 2016

Yeah I understand your position Eduardo but I if you could just check it out, I went all around and things looked good.

@ern ern force-pushed the SAK-30439 branch 2 times, most recently from 31321dd to bdd045f Compare March 3, 2016 15:21
@jonespm
Copy link
Contributor

jonespm commented Mar 3, 2016

@juanjmerono It looks like the error with it freezing is this one. sass/libsass#1931 I only see one place where this is an error for us in _defaults.scss.

I think Earle will update this.

@ern
Copy link
Contributor Author

ern commented Mar 3, 2016

thanks @jonespm updated

@SedueRey
Copy link
Contributor

SedueRey commented Mar 4, 2016

I've been testing and I just have seen two little issues (very tiny).

On pom.xml, the <outputStyle>nested</outputStyle> should be <outputStyle>compressed</outputStyle>, if anyone wants to see it uncompressed can change it on its own branch :)

The only problem I've seen removing compass is on a default style for ul and ol, if you could add this 4 lines to base/_defaults.scss file would be great, this lines reset the behaviour for some list UI (I've seen, at least, sitesNav, toolbar and profile).

ul, ol {
    list-style: none;
    padding: 0 0 0 0;
}

Now it compiles faster than ever!!

@ern
Copy link
Contributor Author

ern commented Mar 4, 2016

thanks @SedueRey for reviewing I updated the PR with your suggestions

@ern ern removed the needs review label Mar 4, 2016
ern added a commit that referenced this pull request Mar 4, 2016
SAK-30439 switch to libsass for morpheus
@ern ern merged commit ffaa179 into sakaiproject:master Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants