-
-
Notifications
You must be signed in to change notification settings - Fork 978
SAK-30439 switch to libsass for morpheus #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm going to test this if it has side-effects. |
I was not able to compile with this new libsass at all. The
|
I'm very afraid of this changes right now that we are trying to fix all problems related to morpheus to release 11 |
Yeah I understand your position Eduardo but I if you could just check it out, I went all around and things looked good. |
31321dd
to
bdd045f
Compare
@juanjmerono It looks like the error with it freezing is this one. sass/libsass#1931 I only see one place where this is an error for us in _defaults.scss. I think Earle will update this. |
thanks @jonespm updated |
I've been testing and I just have seen two little issues (very tiny). On The only problem I've seen removing compass is on a default style for
Now it compiles faster than ever!! |
thanks @SedueRey for reviewing I updated the PR with your suggestions |
SAK-30439 switch to libsass for morpheus
Removed ruby sass and compass switched to libsass which is much faster.
Re created all the mixins we were using in compass.
There may still be some small issues here and there but we should just create new jira's for those.