Skip to content

chore: add os and fs detectors #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

chore: add os and fs detectors #280

merged 1 commit into from
Apr 3, 2025

Conversation

saidsef
Copy link
Owner

@saidsef saidsef commented Apr 3, 2025

No description provided.

@saidsef saidsef added the enhancement New feature or request label Apr 3, 2025
@saidsef saidsef self-assigned this Apr 3, 2025
@saidsef
Copy link
Owner Author

saidsef commented Apr 3, 2025

/code pr

Copy link
Owner Author

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖
I'll review the changes in this PR:

.github/workflows/release.yml

The changes improve security by using secrets.GITHUB_TOKEN instead of github.token, which follows GitHub's recommended security practices. Error handling is also enhanced in the release creation logic:

  1. Fixed a typo in the error comment ("alredy" → "already")
  2. Better error handling structure with proper try/catch flow
  3. Added missing environment variable declaration

Good improvements to the workflow reliability.

libs/index.mjs

  1. Replaced FastifyInstrumentation with FsInstrumentation
  2. Added osDetector to resource detection
  3. Reordered the instrumentation list for better organization

These changes enhance the telemetry capabilities by adding file system instrumentation and OS detection while removing Fastify-specific instrumentation.

package.json and package-lock.json

  1. Version bump from 3.4.4 to 3.4.5
  2. Dependency changes:
    • Removed @opentelemetry/instrumentation-fastify
    • Added @opentelemetry/instrumentation-fs

The changes look appropriate and maintain version consistency between the files.

Overall, this PR makes good improvements to security practices, error handling, and telemetry capabilities. The dependency updates are consistent with the implementation changes.

> claude-3-7-sonnet-latest [pr | 2]

@saidsef saidsef requested a review from Copilot April 3, 2025 22:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@saidsef saidsef merged commit 68040b1 into main Apr 3, 2025
7 checks passed
@saidsef saidsef deleted the os-fs-detector branch April 3, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant