Skip to content

ci: add github actions for lint and format #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 1, 2024
Merged

ci: add github actions for lint and format #156

merged 7 commits into from
Oct 1, 2024

Conversation

saidsay-so
Copy link
Owner

@saidsay-so saidsay-so commented Sep 18, 2024

No description provided.

@saidsay-so saidsay-so force-pushed the ci branch 2 times, most recently from 0175787 to 800e79c Compare September 18, 2024 09:39
Use GitHub Actions for formatting and lints
@saidsay-so saidsay-so requested a review from asomers September 21, 2024 09:56
Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By moving Clippy from cirrus to github, you've also changed what gets checked. FreeBSD-specific code no longer gets checked by Clippy, whereas Linux-specific code now does. Is that deliberate?

@saidsay-so
Copy link
Owner Author

By moving Clippy from cirrus to github, you've also changed what gets checked. FreeBSD-specific code no longer gets checked by Clippy, whereas Linux-specific code now does. Is that deliberate?

No, I just forgot to add the FreeBSD target.

@saidsay-so saidsay-so requested a review from asomers September 25, 2024 09:41
@saidsay-so saidsay-so merged commit 0ef5017 into master Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants