tests: store SVG and URI values to files #1272
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses issue #1264.
Moved hardcoded expectedSVG and expectedTokenURI strings from test files to separate files under tests/data/
Used vm.readFile to load the content in both generateSVG.t.sol and tokenURI.t.sol
Ensured test logic remains intact and structure unchanged
No other modifications to business logic
Let me know if you'd like the file locations to be changed or prefer another folder structure for test fixtures.
Thanks in advance!