Skip to content

chore: just scripts #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

chore: just scripts #1254

merged 5 commits into from
Jun 11, 2025

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg commented May 22, 2025

Implements https://github.com/sablier-labs/command-center/issues/151

lmk if you like this. If yes, we can implement the same in the other repos

See https://github.com/sablier-labs/devkit

@PaulRBerg PaulRBerg changed the base branch from staging to staging-blast May 22, 2025 16:57
@PaulRBerg PaulRBerg changed the base branch from staging-blast to staging May 22, 2025 16:57
@PaulRBerg PaulRBerg force-pushed the chore/just branch 2 times, most recently from c8d0ee1 to 28d0994 Compare May 22, 2025 16:59
@PaulRBerg PaulRBerg changed the base branch from staging to staging-blast May 22, 2025 16:59
@PaulRBerg PaulRBerg changed the base branch from staging-blast to staging May 22, 2025 17:00
@PaulRBerg PaulRBerg force-pushed the chore/just branch 3 times, most recently from 08a9c99 to 6518523 Compare May 24, 2025 11:29
@PaulRBerg
Copy link
Member Author

CI error is because we need to install ni in CI:

bash: line 1: na: command not found

@smol-ninja
Copy link
Member

I see. In that case, will na become a pre-requirement to work on this repo (because scripts won't even run locally)? If that's correct, then we will be relying on ni to be our main package manager? Not sure if thats a good approach. Wdyt?

@PaulRBerg
Copy link
Member Author

PaulRBerg commented May 27, 2025

We don't need ni as a dependency in this repo — only for it to be installed as a global dependency on everyone's machines.

That's a reasonable ask, just like we require everyone to install npm/ bun/ yarn/ etc.

The alternative is to implement a $PM environment variable in the devkit repo, and manually set it in the justfile file of each dependent repo.

Side note — maybe we should extend the vscode-setup repo and provide something like a general shellscript that @sablier-labs/everybody should run?

@smol-ninja
Copy link
Member

Understand. In that case, we should add it under Pre Requisites.

@smol-ninja
Copy link
Member

Bumping this up, in case you have missed my review @PaulRBerg, ignore otherwise.

@PaulRBerg
Copy link
Member Author

Sorry @smol-ninja haven't missed your review, just got bogged down with my Indexers refactor. I'll pick this up this week.

Thanks for your review

@PaulRBerg
Copy link
Member Author

The PR is ready for re-review — and perhaps merge this time! @sablier-labs/evm

build: bump deps
fix: fix shub's pr feedback
@PaulRBerg
Copy link
Member Author

Merging now — make sure you have just and @antfu/ci on your machines, @sablier-labs/evm 🫡

https://github.com/sablier-labs/team-setup/blob/94103a1b664019ee275de4758e2823ca542adf1c/install-globals.sh

@PaulRBerg PaulRBerg merged commit 07303b1 into staging Jun 11, 2025
9 checks passed
@PaulRBerg PaulRBerg deleted the chore/just branch June 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants