Use the same profile name for both Cargo and wasm-pack #1489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
wasm-pack
with a custom profile (wasm-pack build . --profile custom_profile_name
), the Cargo profile with namecustom_profile_name
will be used, butwasm-pack
will use a profile calledcustom
.More concisely,
Cargo will use
[profile.custom_profile_name]
, whereaswasm-pack
will use[package.metadata.wasm-pack.profile.custom]
This PR makes
wasm-pack
use the custom profile name provided with the--profile
option so thatwasm-pack
will now use[package.metadata.wasm-pack.profile.custom_profile_name]
.Closes #1488.
Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨