Update AudioBufferSourceNode to latest W3C draft
#3978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Unfortunately this would be a breaking change, so we have to be a bit more careful.
- Its fine just updating parameter names in WebIDL, but that also changes method names in the generated Rust code, which would be a breaking change. You can use this to adjust the names in the generator.
- The removal of methods is fine as long as they actually got removed from browsers. Could you check the usual browsers? (you can also check their source code if that's easier)
A changelog entry has to be added as well.
|
Replaced by #4020. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the
AudioBufferSourceNodeWebIDL file is updated to the latest version of the W3C draft at https://webaudio.github.io/web-audio-api/#AudioBufferSourceNode.Namely, the
grain_prefix from theoffsetanddurationinput parameters is removed.The removed
attribute EventHandler onended;can be accessed through theAudioScheduledSourceNodebase class.