Add example with WASM audio worklet #3017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaslihotzki
force-pushed
the
wasm-audio-worklet
branch
2 times, most recently
from
33a8682 to
9ad6a3c
Compare
|
Thanks! I don't have the time to do an in-depth review of the code here but @Liamolucko would you be perhaps interested in doing so? If not no worries I'm happy to merge regardless. |
lukaslihotzki
force-pushed
the
wasm-audio-worklet
branch
from
9ad6a3c to
f82937a
Compare
|
An in-depth review would be great if possible. Note this example would benefit from the feature proposed in #3019. This example could be used as a test case if this feature is implemented. |
joaofreires
reviewed
Aug 5, 2022
Liamolucko
reviewed
Aug 5, 2022
lukaslihotzki
force-pushed
the
wasm-audio-worklet
branch
4 times, most recently
from
d08f1b6 to
b79323e
Compare
lukaslihotzki
force-pushed
the
wasm-audio-worklet
branch
4 times, most recently
from
c173446 to
b553911
Compare
Liamolucko
reviewed
Aug 13, 2022
lukaslihotzki
force-pushed
the
wasm-audio-worklet
branch
from
b553911 to
47fc753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example runs an oscillator in WASM inside an audio worklet. Volume and frequency is controllable in the UI exposed by the main thread. A design goal was to abstract worklet and JS module handling in a way that can be handled by a library with minimal annoyance for application developers. Therefore, the Rust modules gui, oscillator, wasm_audio, and dependent_module are fairly decoupled.