test running rustfmt on web-sys bindings. #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh oops, I forgot about this, thanks for looking into it! I believe this was done for CI time historically but I think it's fine to merge now. Thanks! |
|
I've unfortunately ended up having to undo this in 0f0d5ee due to failures to upload where the formatted file is too large for github. |
|
@alexcrichton I've worked around that in the past by splitting it into multiple separate files. Each file must be less than 50 MB, but you can have multiple 50 MB files just fine. Of course, it's questionable whether we should be uploading 50+ MB files in the first place... |
|
I think this has to do with generated code so it's unfortunately a bit nontrivial to split up :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.