The example should output "Hello from Rust!" #1931
Conversation
The HTML says the console would output Hello from Rust!, but instead it outputs Hello, World! This is a proposed fix.
The HTML says the console would output "Hello from Rust!" but instead it outputs "Hello, World!". This is a proposed fix.
|
My thought: Leave the example's message unchanged, or change it to: Where |
Some change is needed to match the guidance on HTML with the actual output on the JS console, in my humble opinion, this would reduce the level of frustration of a learner who is following the examples ("is the output different because this example is not doing what it says it would, or am I doing something wrong?"). |
|
Ha, sorry for misreading your original PR's message. I see the reason of this PR now. I never ran the example or read it carefully so I didn't know that the messages are mismatched. This PR fixes the mismatch. It's turn out that the name Rust has to be retrieved from a JS's function and I think it's a bit weird. That's the reason of my comment. Now, I think the message in Because "Hello..." is not the only message output there. Again, sorry about the confusion! |
|
Oh, by all means, thanks for your comments and attention. I will also make sure my future PRs have a clear explanation for the motivation. |
|
I am just a random contributor, not the one who make decisions in this project. I just voice my thought, you may do what I say if you agree with it. Otherwise, let's wait for response from the project's members. |
|
Ok, I see... by all means your suggestions are welcome, but I will wait for the owner of this wasm-bindgen example to tell us the way forward. |
|
Seems reasonable to me, I'm fine with tweaking this as necessary! |
Thanks for your examples, I'm learning a lot from them.
In this one in particular, the HTML says the user should see "Hello from Rust!" on the console, however it says "Hello, World!".
This is a proposed fix.