Changing wasm-in-wasm example to be async #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alexcrichton merged 1 commit into rustwasm:master from Pauan:async-wasm-in-wasm-example

Dec 9, 2019

Contributor

Pauan commented Dec 7, 2019

This has three big benefits:

It removes an unsafe usage.
It uses the idiomatic async APIs rather than the soft deprecated sync APIs.
The old code would error with a .wasm module which is bigger than 4KB. But the new code works no matter how big the .wasm file is.


          Changing wasm-in-wasm example to be async

6b36fec

alexcrichton merged commit b71b136 into rustwasm:master

Contributor

alexcrichton commented Dec 9, 2019

Nice!

Pauan deleted the async-wasm-in-wasm-example branch

December 9, 2019 20:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet