Add advisory for tor-circmgr TROVE-2024-003 #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijackson
commented
May 15, 2024
Comment on lines
2
to
27
| [advisory] | ||
| id = "RUSTSEC-0000-0000" | ||
|
|
||
| package = "tor-circmgr" | ||
|
|
||
| date = "2024-05-15" | ||
|
|
||
| url = "https://github.com/mystuff/mycrate/issues/123" | ||
|
|
||
| references = ["https://gitlab.torproject.org/tpo/core/arti/-/issues/1409"] | ||
|
|
||
| # There doesn't seem to be an applicable category for | ||
| # "privacy weaking due to protocol misimplementation". | ||
| # There ought to be "information-leak". | ||
| categories = [] | ||
|
|
||
| keywords = ["tor", "privacy", "information-leak"] | ||
|
|
||
| # We have applied for a CVE | ||
| aliases = ["TROVE-2024-003"] | ||
|
|
||
| related = ["TROVE-2024-004"] | ||
|
|
||
| # This is the default for parsers, apparently, but legally, | ||
| # we ought to have an explicit licence grant, which this can serve as: | ||
| license = "CC0-1.0" |
There was a problem hiding this comment.
Thanks for the review. I prefer to keep the newlines, unless they're against RUSTSEC policy, as I find it makes things more readable.
I seem to have failed to set the URL field indeed. I will fix that.
|
Thank you for the report, and sorry for the delay! I've added the CVE ID now that a CVE has been assigned. I'll merge as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are going to be two advisories. There are in fact two bugs due to entirely different code paths, with similar impact.
I am making these as separate MRs since doing otherwise would probably break some tooling.