Fix HiDPI vs. set_cursor_icon for web #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhysicalSize is recorded as canvas.size, whereas LogicalSize is stored as canvas.style.size. The previous cursor behavior on stdweb clobbered all style - thus losing the LogicalSize.
michaelkirk
changed the title
michaelkirk
commented
Aug 14, 2020
| @@ -165,8 +165,7 @@ impl Window { | |||
| CursorIcon::RowResize => "row-resize", | |||
| }; | |||
| *self.previous_pointer.borrow_mut() = text; | |||
| self.canvas | |||
| .set_attribute("style", &format!("cursor: {}", text)); | |||
| backend::set_canvas_style_property(self.canvas.raw(), "cursor", text); | |||
There was a problem hiding this comment.
here's the bug - clobbering everything in style.
michaelkirk
added a commit
to michaelkirk/abstreet
that referenced
this pull request
Sep 6, 2020
Bug fixes we want merged since 0.22.2: - web: DPI vs. custom cursor icon: rust-windowing/winit#1652 - web: v-scroll inverted rust-windowing/winit#1665 - mac: h-scroll inverted rust-windowing/winit#1696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicalSize is recorded as canvas.size, whereas LogicalSize is stored
as canvas.style.size.
The previous cursor behavior on stdweb clobbered all style - thus losing
the LogicalSize.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersHere are some before/after screencasts from the app where I encountered this bug. It's hard to make sense of looping GIFs - the video starts when my cursor is on the right DOM-inspector pane, then the canvas is made much larger as my mouse enters the canvas because our app sets the cursor icon (to "auto" so it's an invisible cursor change, but enough to trigger the bug).
You can see that as soon as we edit the cursor, we lose the style info for the canvas, thus lose it's "logical" sizing, relying on the "physical" sizing.
before
after
