Refactor mock ring accessor API; add typed accessors #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongnelson
requested review from
alexandruag,
andreeaflorescu,
jiangliu,
slp,
stsquad,
epilys and
stefano-garzarella
as code owners
- Introduces the RingAccess trait for endianness conversion in mock ring elements - Adds typed accessor methods (e.g., load_flags, store_ring) to SplitQueueRing - Refactors test/mocks to use the new accessors instead of raw Ref/ArrayRef and manual conversion - Adds minimal test coverage for flag and event accessors - Fixes rust-vmm#123 Signed-off-by: Nelson Wong <[email protected]>
wongnelson
force-pushed
the
issue123-typed-ring-accessors
branch
from
167651b to
3d5be44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Addresses #123
This PR refactors the mock queue ring API by:
RingAccesstrait to handle endianness conversions for ring elements in tests.load_flags,store_flags,load_event,store_event, etc.) toSplitQueueRingso that test code no longer directly manipulates raw memory or does manual endianness conversion.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.