Skip to content

Archive inactive compiler WGs #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Apr 4, 2025

This patch does some cleanup.

  • Archives:
    • wg-debugging
    • wg-polymorphization
    • wg-self-profile
    • wg-incr-comp
  • Renames active groups where work is happening, removing the "Working Group" wording (which T-compiler is sunsetting).

This is part of the work stemming from rust-lang/compiler-team#848

Thanks

@apiraino apiraino force-pushed the archive-compiler-wgs branch from 5a7feba to d5281d6 Compare April 4, 2025 10:42
@apiraino
Copy link
Contributor Author

apiraino commented Apr 4, 2025

cc @Kobzol / @marcoieni

I'm not sure how to fix this CI error 🤔

[ERROR rust_team::validate] validation error: access for rust-lang/wg-debugging is invalid: 'wg-debugging' is not configured as a GitHub team for the 'rust-lang' org

(I have just moved the team .toml file into the archive)

@Kobzol
Copy link
Contributor

Kobzol commented Apr 4, 2025

There is a wg-debugging repo, that should also be archived (and its access.teams should be thus empty).

Btw if the "working group" suffix is dropped, it might look a bit weird on the website (it will show just "Binary size" as the header).

@marcoieni
Copy link
Member

I tried to improve the error message in #1764 👍

@apiraino
Copy link
Contributor Author

apiraino commented Apr 4, 2025

I get a new error locally, unrelated to this PR:

[ERROR rust_team::validate] validation error: GitHub user `m-rph` changed username to `PartiallyUntyped`

Should I fix this first in a separate PR? What do we do in these cases?

@Kobzol
Copy link
Contributor

Kobzol commented Apr 4, 2025

Yeah, we should do that in a separate PR. It's a bit unfortunate, but when a user in the team DB renames themselves, it currently blocks team's CI 😅

@apiraino
Copy link
Contributor Author

apiraino commented Apr 4, 2025

Yeah, we should do that in a separate PR. It's a bit unfortunate, but when a user in the team DB renames themselves, it currently blocks team's CI 😅

Must be my lucky day. Exactly while I was changing stuff here :D

@apiraino apiraino force-pushed the archive-compiler-wgs branch from d5281d6 to 4723d6d Compare April 4, 2025 16:28
@apiraino apiraino mentioned this pull request Apr 4, 2025
@apiraino apiraino force-pushed the archive-compiler-wgs branch from 4723d6d to 80ae8fe Compare April 7, 2025 15:33
Copy link

github-actions bot commented Apr 7, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    ❌ Deleting team 'rust-lang/wg-incr-comp'
    ❌ Deleting team 'rust-lang/wg-debugging'
    ❌ Deleting team 'rust-lang/wg-rustc-reading-club'
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rustc-reading-club':
      Permission Changes:
        Removing team 'wg-rustc-reading-club''s write permission 
    📝 Editing repo 'rust-lang/wg-debugging':
      Archive
      Permission Changes:
        Removing team 'wg-debugging''s write permission 
    📝 Editing repo 'rust-lang/wg-incr-comp':
      Archive
      Permission Changes:
        Removing team 'wg-incr-comp''s write permission 

@marcoieni
Copy link
Member

In case this is ready, probably a team-repo-admin should review this (not infra admins) since it changes teams 👍

@apiraino apiraino force-pushed the archive-compiler-wgs branch from 80ae8fe to feba264 Compare April 7, 2025 15:58
@apiraino
Copy link
Contributor Author

apiraino commented Apr 7, 2025

Btw if the "working group" suffix is dropped, it might look a bit weird on the website (it will show just "Binary size" as the header).

I thought it was ok but since you mention maybe it was not that ok, so I have added a "working area" suffix for some of them, which is not great either but it feels better (and I am uninspired to find a better title anyway). At least it's coherent with what we have in the forge

@Kobzol
Copy link
Contributor

Kobzol commented Apr 7, 2025

Yeah, it's hard to find a good name. Working group actually was a pretty good match 😆 Working area sounds fine.

@jackh726
Copy link
Member

jackh726 commented Apr 7, 2025

r? @davidtwco @wesleywiser

(particulary on "working area" naming, I guess)

@davidtwco
Copy link
Member

I'd probably make the remaining groups into marker teams so that they're just ping lists - I think that is what we're intending with these changes.

@apiraino apiraino force-pushed the archive-compiler-wgs branch 4 times, most recently from dad073c to 874e8ff Compare April 10, 2025 12:46
@apiraino
Copy link
Contributor Author

@Kobzol I think we're done here

(to be clear: I've intentionally only touched files marked as compiler subteams)

@apiraino apiraino force-pushed the archive-compiler-wgs branch from 874e8ff to dbef395 Compare April 10, 2025 13:18
@Kobzol
Copy link
Contributor

Kobzol commented Apr 10, 2025

Fine by me :) (I can't approve it though)

@apiraino
Copy link
Contributor Author

apiraino commented Apr 10, 2025

cc @technetos for a last look and push the merge button :^)

r? @technetos

@Kobzol Kobzol requested a review from jackh726 April 10, 2025 13:58
@apiraino apiraino force-pushed the archive-compiler-wgs branch 4 times, most recently from ecdd165 to 82ba2ac Compare April 14, 2025 14:41
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all leads from archived teams too, please.

@jackh726
Copy link
Member

Archived teams still have the leads?

@apiraino apiraino force-pushed the archive-compiler-wgs branch from bac5125 to 9dd166f Compare April 17, 2025 15:30
@apiraino apiraino force-pushed the archive-compiler-wgs branch from 9dd166f to 82c1e4b Compare April 17, 2025 15:32
@apiraino
Copy link
Contributor Author

Archived teams still have the leads?

sorry. pushed those, too

@jackh726 jackh726 added this pull request to the merge queue Apr 20, 2025
Merged via the queue into rust-lang:master with commit e8f1ae3 Apr 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants