fix formatting mods inside cfg_if macro #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
changed the title
calebcartwright
force-pushed
the
cfg-if-mods
branch
from
871c475 to
19e8746
Compare
calebcartwright
force-pushed
the
cfg-if-mods
branch
from
3cc2408 to
3b5ae48
Compare
calebcartwright
force-pushed
the
cfg-if-mods
branch
from
3b5ae48 to
5934944
Compare
|
Thank you! |
|
@calebcartwright I would like to keep it to 1.5.0 for now, as I would like to add more tests against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3253
As this fix will allow mods defined within
cfg_ifmacro to be formatted, I suspect that #3253 could probably be closed, unless the ask in that issue is to cover any macro.