Improve slice indexing assertion #29984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
str uses a separate function to put the formatting there |
|
Yeah I think the If, however, a concrete function in libcore were provided (e.g. not generic), then it could be as fancy as it wants! |
|
That should be marked |
|
@Manishearth might as well. |
Manishearth
force-pushed
the
slice-assert
branch
2 times, most recently
from
cae8692 to
a1ff4b4
Compare
Manishearth
force-pushed
the
slice-assert
branch
from
a1ff4b4 to
5c873be
Compare
|
Updated. Error message could be improved. |
Closed
bors
added a commit
that referenced
this pull request
Nov 23, 2015
I'd like to have the message print out the index and length values like it does elsewhere, but I'm not sure how to do that without affecting perf here. Will `assert!(cond, "index out of bounds got {} but len is ", idx, len)` make things slower? It calls `panic_fmt` which is marked as cold but also calls `format_args!`, and I don't know if that allocates or does any heavy lifting.
cc @alexcrichton @gankro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have the message print out the index and length values like it does elsewhere, but I'm not sure how to do that without affecting perf here. Will
assert!(cond, "index out of bounds got {} but len is ", idx, len)make things slower? It callspanic_fmtwhich is marked as cold but also callsformat_args!, and I don't know if that allocates or does any heavy lifting.cc @alexcrichton @gankro