Pretend in bootstrap snapshot tests that we always build in-tree LLVM #143474
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I'm not 100%, would like to double-check this change in #143126. |
|
IIUC, this is because the CI configuration is changing the test input? |
|
We will need to normalize more things in the bootstrap test config, yeah. I don't understand why the LLVM build step disappeared though, when LLVM was modified, it should be built, not downloaded, so if anything the step should appear (but really it should be called in both cases). |
|
Yeah, it should be unconditionally called (a no-op step is fine), but it should still appear... |
|
@bors r+ p=1 (bootstrap fix blocking other PRs) |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 5, 2025
Pretend in bootstrap snapshot tests that we always build in-tree LLVM Otherwise, depending on whether CI LLVM is inhibited or if an externally-provided LLVM is used, bootstrap host LLVM build step could be missing in step snapshots. Note that I'm not sure if this is the *right* solution (this might be *a* solution). I imagine we do want to control for the set of configuration that these snapshot tests are run, as much as possible. r? `@Kobzol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, depending on whether CI LLVM is inhibited or if an externally-provided LLVM is used, bootstrap host LLVM build step could be missing in step snapshots.
Note that I'm not sure if this is the right solution (this might be a solution). I imagine we do want to control for the set of configuration that these snapshot tests are run, as much as possible.
r? @Kobzol