mir-opt: execute MatchBranchSimplification after GVN

[dianqk]

This can provide more opportunities for MatchBranchSimplification.

Currently, rustc does not optimize the following code into a single statement at mir-opt, and this PR fixes the first case.

pub fn match1(c: bool, v1: i32, v2: i32) -> i32 {
    if c { v1 - v2 } else { v1 - v2 }
}

pub fn match2(c: bool, v1: i32) -> i32 {
    if c { v1 - 1 } else { v1 - 1 }
}

https://rust.godbolt.org/z/Y8xPMjrfM

r? mir-opt

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[dianqk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 5881b7c with merge 1aadc7f...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1aadc7f (1aadc7fccd4d64783aa82b79a6e7df7f08f12787)

[rust-timer]

Finished benchmarking commit (1aadc7f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.2%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[1.0%, 6.1%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-6.3%, -0.5%]	6
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-0.2%	[-6.3%, 6.1%]	10

Cycles

Results (primary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Binary size

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.5%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.0%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.4%, 0.5%]	11

Bootstrap: 773.608s -> 771.589s (-0.26%)
Artifact size: 365.05 MiB -> 365.07 MiB (0.01%)

[dianqk]

r? mir-opt

[oli-obk]

@bors r+ rollup

[bors]

📌 Commit 5881b7c has been approved by oli-obk

It is now in the queue for this repository.