Skip to content

Stabilize slice_as_chunks library feature #139656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Stabilize slice_as_chunks library feature #139656

merged 2 commits into from
Apr 29, 2025

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Apr 11, 2025 •
edited
Loading

Draft as this needs #139163 to land first.

FCP: #74985 (comment)

Methods being stabilized are:

impl [T] {
    const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]);
    const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]);
    const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]];
    const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]);
    const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]);
    const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];
}

(FCP's not done quite yet, but will in another day if I'm counting right.) FCP Complete: #74985 (comment)

@scottmcm scottmcm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Apr 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm scottmcm force-pushed the stabilize-slice-as-chunks branch from 1f3dfae to 6cfdd53 Compare April 11, 2025 04:17
@scottmcm scottmcm mentioned this pull request Apr 11, 2025
Open
6 tasks
@scottmcm scottmcm closed this Apr 13, 2025
@scottmcm scottmcm reopened this Apr 13, 2025
@scottmcm scottmcm marked this pull request as ready for review April 13, 2025 07:30
@rustbot
Copy link
Collaborator

rustbot commented Apr 13, 2025

The Miri subtree was changed

cc @rust-lang/miri

@scottmcm scottmcm removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Apr 13, 2025
@scottmcm
Copy link
Member Author

@rust-lang/libs-api I wanted to drop you a ping because there has been a reasonable amount of discussion during the FCP, so if you want me to hold off this for a bit to give you discussion time, let me know.

(I haven't seen any indication from comments that you've changed your minds, but it might just not have made it into the thread.)

@BurntSushi
Copy link
Member

Aye yeah, I'm still good with this. But given the discussion, holding for a second from another libs-api member seems prudent.

@dtolnay
Copy link
Member

dtolnay commented Apr 13, 2025

LGTM as well. Thank you. We have talked about this feature across at least a half dozen library API team meetings and not diverged from favoring this design.

dtolnay
dtolnay reviewed Apr 13, 2025
View reviewed changes
library/core/src/slice/mod.rs
@@ -1314,7 +1314,6 @@ impl<T> [T] {
/// # Examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the section above (which I cannot comment because it is too far from the diff) we need to strike "This check will most probably get changed to a compile time error before this method gets stabilized."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that had even been mentioned in #74985 (comment) and I forgot.

Did a pass over the docs to fix that bit, elaborate on the resulting lengths, and also add a cross-references between these methods and as_flattened(_mut).

@rustbot ready

@dtolnay dtolnay assigned dtolnay and unassigned ibraheemdev Apr 13, 2025
@dtolnay dtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025
@scottmcm
Improve rustdocs on slice_as_chunks methods
c49ddc0 
Also mention them from `as_flattened(_mut)`.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2025
@scottmcm
Copy link
Member Author

Friendly ping here, @dtolnay

dtolnay
dtolnay approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Apr 28, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 28, 2025

📌 Commit c49ddc0 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 28, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#139656 - scottmcm:stabilize-slice-as-chunks…
19928c4 
…, r=dtolnay

Stabilize `slice_as_chunks` library feature

~~Draft as this needs rust-lang#139163 to land first.~~

FCP: rust-lang#74985 (comment)

Methods being stabilized are:
```rust
impl [T] {
    const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]);
    const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]);
    const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]];
    const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]);
    const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]);
    const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];
}
```

~~(FCP's not done quite yet, but will in another day if I'm counting right.)~~ FCP Complete: rust-lang#74985 (comment)
@ChrisDenton ChrisDenton mentioned this pull request Apr 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge of rust-lang#140414 - ChrisDenton:rollup-sgoos3d, r=ChrisD…
140a9b4 
…enton

Rollup of 10 pull requests

Successful merges:

 - rust-lang#139308 (add autodiff inline)
 - rust-lang#139656 (Stabilize `slice_as_chunks` library feature)
 - rust-lang#140022 (allow deref patterns to move out of boxes)
 - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied)
 - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases)
 - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`)
 - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs)
 - rust-lang#140394 (Make bootstrap git tests more self-contained)
 - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure)
 - rust-lang#140402 (only return nested goals for `Certainty::Yes`)

Failed merges:

 - rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88)

r? `@ghost`
`@rustbot` modify labels: rollup
@ChrisDenton ChrisDenton mentioned this pull request Apr 28, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2025
@bors
Auto merge of rust-lang#140415 - ChrisDenton:rollup-r0631fv, r=ChrisD…
1b8ab72 
…enton

Rollup of 10 pull requests

Successful merges:

 - rust-lang#139308 (add autodiff inline)
 - rust-lang#139656 (Stabilize `slice_as_chunks` library feature)
 - rust-lang#140022 (allow deref patterns to move out of boxes)
 - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied)
 - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases)
 - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`)
 - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs)
 - rust-lang#140394 (Make bootstrap git tests more self-contained)
 - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure)
 - rust-lang#140402 (only return nested goals for `Certainty::Yes`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 17495e0 into rust-lang:master Apr 29, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 29, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2025
@rust-timer
Unrolled build for rust-lang#139656
fbc7514 
Rollup merge of rust-lang#139656 - scottmcm:stabilize-slice-as-chunks, r=dtolnay

Stabilize `slice_as_chunks` library feature

~~Draft as this needs rust-lang#139163 to land first.~~

FCP: rust-lang#74985 (comment)

Methods being stabilized are:
```rust
impl [T] {
    const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]);
    const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]);
    const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]];
    const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]);
    const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]);
    const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];
}
```

~~(FCP's not done quite yet, but will in another day if I'm counting right.)~~ FCP Complete: rust-lang#74985 (comment)
@scottmcm scottmcm deleted the stabilize-slice-as-chunks branch April 29, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
7 participants
@scottmcm @rustbot @rust-log-analyzer @BurntSushi @dtolnay @bors @ibraheemdev