Switch time to jiff for time formatting in ICE dumps

[clubby789]

Due to jhpratt/deranged#21, Clippy, R-A and Miri currently fail to build if we bump to 0.4.1, pulled in via time. Add some specific type annotations so we don't have to just pin it.

I can open 3 PRs to the tool repos if preferred, but I thought it might be easier to do this than to pin the transitive dep and go back and remove it once the changes are synced back.

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[lnicola]

It's fine from the r-a side.

[RalfJung]

Maybe we should re-consider our use of this dependency if it breaks entirely unrelated code in this way.

[clubby789]

Maybe we should re-consider our use of this dependency if it breaks entirely unrelated code in this way.

Currently, it's pulled in via time, which is only used in rustc_driver_impl for formatting the rustc-ice files, which is probably avoidable. Will look into that

[rustbot]

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

[clubby789]

I don't feel very confident about having our own bespoke formatting, so tried switching over to chrono, which does have the downside of pulling in a different set of dependencies - which at least currently don't cause issues all over our tools and tests

[ChrisDenton]

It seems like a heavy weight dependency just for formatting rustc-ice files. Is there nothing else that can be used?

[Veykril]

https://docs.rs/jiff/latest/jiff/ maybe?

[clubby789]

Certainly seems more lightweight (and is already in use in the tree)

[jhpratt]

FYI I am reconsidering whether to yank the release in question given the apparently larger scope of breakage than I initially assumed would happen. Keep an eye on jhpratt/deranged#21 for updates. I'll have a definitive answer in a day or two max (currently quite busy and am abroad).

[jhpratt]

re. above, the relevant version was yanked, so version bumps for Rust should work as expected now