tidy: Fix paths to coretests and alloctests
#139123
Merged
+35
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-tidy
|
Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
|
Looks like my changes to Since those particular tests which CI detected exercise the internals of collections, they currently have to be part of |
thaliaarchi
force-pushed
the
core-alloc-test-paths
branch
from
2db2a3f to
d5760fe
Compare
For cg_clif at least this is because the core tests don't run in CI here. In any case yesterday's sync PR fixed all references in cg_clif. |
bjorn3
reviewed
Mar 31, 2025
bjorn3
reviewed
Mar 31, 2025
thaliaarchi
force-pushed
the
core-alloc-test-paths
branch
from
d5760fe to
d3581b2
Compare
|
Thanks for the review. I've rebased to incorporate the Cranelift changes and addressed your feedback. |
thaliaarchi
force-pushed
the
core-alloc-test-paths
branch
from
d3581b2 to
38b933a
Compare
Following `rust-lang#135937` and `rust-lang#136642`, tests for core and alloc are in coretests and alloctests. Fix tidy to lint for the new paths. Also, update comments referring to the old locations. Some context for changes which don't match that pattern: * library/std/src/thread/local/dynamic_tests.rs and library/std/src/sync/mpsc/sync_tests.rs were moved under library/std/tests/ in 332fb7e (Move std::thread_local unit tests to integration tests, 2025-01-17) and b8ae372 (Move std::sync unit tests to integration tests, 2025-01-17), respectively, so are no longer special cases. * There never was a library/core/tests/fmt.rs file. That comment previously referred to src/test/ui/ifmt.rs, which was folded into library/alloc/tests/fmt.rs in 949c966 (move format! interface tests, 2020-09-08).
thaliaarchi
force-pushed
the
core-alloc-test-paths
branch
from
38b933a to
3af666e
Compare
thaliaarchi
changed the title
coretests and alloctestscoretests and alloctests
|
Great. We should be good to go now. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
…=bjorn3 tidy: Fix paths to `coretests` and `alloctests` Following `rust-lang#135937` and `rust-lang#136642`, tests for core and alloc are in coretests and alloctests. Fix tidy to lint for the new paths. Also, update comments referring to the old locations. Some context for changes which don't match that pattern: - `library/std/src/thread/local/dynamic_tests.rs` and `library/std/src/sync/mpsc/sync_tests.rs` were moved under `library/std/tests/` in 332fb7e (Move std::thread_local unit tests to integration tests, 2025-01-17) and b8ae372 (Move std::sync unit tests to integration tests, 2025-01-17), respectively, so are no longer special cases. - There never was a `library/core/tests/fmt.rs` file. That comment previously referred to `src/test/ui/ifmt.rs`, which was folded into `library/alloc/tests/fmt.rs` in 949c966 (move format! interface tests, 2020-09-08). Now, the only matches for `(alloc|core)/tests` are in `compiler/rustc_codegen_{cranelift,gcc}/patches`. I don't know why CI hasn't broken because those patches can't apply. Or maybe they somehow still can apply? r? `@bjorn3`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
|
It looks like the |
|
Since the failure last time was from the merge commit hash ( |
|
@bors r=bjorn3 |
|
💡 This pull request was already approved, no need to approve it again.
|
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
Rollup of 3 pull requests Successful merges: - rust-lang#139123 (tidy: Fix paths to `coretests` and `alloctests`) - rust-lang#139347 (Only build `rust_test_helpers` for `{incremental,ui}` test suites) - rust-lang#139438 (Prevent a test from seeing forbidden numbers in the rustc version) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2025
Rollup merge of rust-lang#139123 - thaliaarchi:core-alloc-test-paths, r=bjorn3 tidy: Fix paths to `coretests` and `alloctests` Following `rust-lang#135937` and `rust-lang#136642`, tests for core and alloc are in coretests and alloctests. Fix tidy to lint for the new paths. Also, update comments referring to the old locations. Some context for changes which don't match that pattern: - `library/std/src/thread/local/dynamic_tests.rs` and `library/std/src/sync/mpsc/sync_tests.rs` were moved under `library/std/tests/` in 332fb7e (Move std::thread_local unit tests to integration tests, 2025-01-17) and b8ae372 (Move std::sync unit tests to integration tests, 2025-01-17), respectively, so are no longer special cases. - There never was a `library/core/tests/fmt.rs` file. That comment previously referred to `src/test/ui/ifmt.rs`, which was folded into `library/alloc/tests/fmt.rs` in 949c966 (move format! interface tests, 2020-09-08). Now, the only matches for `(alloc|core)/tests` are in `compiler/rustc_codegen_{cranelift,gcc}/patches`. I don't know why CI hasn't broken because those patches can't apply. Or maybe they somehow still can apply? r? `@bjorn3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following
#135937and#136642, tests for core and alloc are in coretests and alloctests. Fix tidy to lint for the new paths. Also, update comments referring to the old locations.Some context for changes which don't match that pattern:
library/std/src/thread/local/dynamic_tests.rsandlibrary/std/src/sync/mpsc/sync_tests.rswere moved underlibrary/std/tests/in 332fb7e (Move std::thread_local unit tests to integration tests, 2025-01-17) and b8ae372 (Move std::sync unit tests to integration tests, 2025-01-17), respectively, so are no longer special cases.library/core/tests/fmt.rsfile. That comment previously referred tosrc/test/ui/ifmt.rs, which was folded intolibrary/alloc/tests/fmt.rsin 949c966 (move format! interface tests, 2020-09-08).Now, the only matches for
(alloc|core)/testsare incompiler/rustc_codegen_{cranelift,gcc}/patches. I don't know why CI hasn't broken because those patches can't apply. Or maybe they somehow still can apply?r? @bjorn3