Skip to content

Improve Lifetime::suggestion #139046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

Improve Lifetime::suggestion #139046

merged 2 commits into from
May 2, 2025

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Mar 28, 2025 •
edited
Loading

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nnethercote nnethercote force-pushed the hir-Lifetime-better branch from be80b19 to effd5cc Compare March 28, 2025 07:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nnethercote nnethercote force-pushed the hir-Lifetime-better branch from effd5cc to 3eda3db Compare March 28, 2025 09:11
@nnethercote nnethercote mentioned this pull request Mar 28, 2025
Merged
@bors
Copy link
Collaborator

bors commented Apr 15, 2025

☔ The latest upstream changes (presumably #139826) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote nnethercote force-pushed the hir-Lifetime-better branch from 3eda3db to 5eb8a5f Compare April 28, 2025 10:45
@nnethercote nnethercote marked this pull request as ready for review April 28, 2025 10:45
@nnethercote
Copy link
Contributor Author

Details in individual commits.

cc @shepmaster

lcnr
lcnr reviewed May 1, 2025
View reviewed changes
nnethercote added 2 commits May 2, 2025 07:13
@nnethercote
Augment impl-trait-missing-lifetime-gated.rs.
b2bf951 
We have coverage for `Foo` and `Foo<T>` but not for `Foo<>`. This commit
adds it. Note that the output has bogus syntax: `impl Foo'a, >`
@nnethercote
Handle Path<> better in error messages.
d42edee 
`Path<>` needs to be distinguished from `Path<T>`. This commit does
that, improving some error messages.
@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025
@nnethercote nnethercote force-pushed the hir-Lifetime-better branch from 5eb8a5f to d42edee Compare May 2, 2025 00:02
@nnethercote
Copy link
Contributor Author

Ok, I have reduced the PR to perturb the carets in the error messages less. It now only makes the changes necessary to fix the malformed error messages.

@lcnr
Copy link
Contributor

lcnr commented May 2, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 2, 2025

📌 Commit d42edee has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2025
VlaDexa added a commit to VlaDexa/rust that referenced this pull request May 2, 2025
@VlaDexa
Rollup merge of rust-lang#139046 - nnethercote:hir-Lifetime-better, r…
d4e9bfb 
…=lcnr

Improve `Lifetime::suggestion`

r? `@lcnr`
@VlaDexa VlaDexa mentioned this pull request May 2, 2025
Closed
@Zalathar Zalathar mentioned this pull request May 2, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2025
@bors
Auto merge of rust-lang#140581 - Zalathar:rollup-ig2jb9v, r=Zalathar
7c96085 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#134034 (handle paren in macro expand for let-init-else expr)
 - rust-lang#137474 (pretty-print: Print shebang at the top of the output)
 - rust-lang#138872 (rustc_target: RISC-V `Zfinx` is incompatible with `{ILP32,LP64}[FD]` ABIs)
 - rust-lang#139046 (Improve `Lifetime::suggestion`)
 - rust-lang#139206 (std: use the address of `errno` to identify threads in `unique_thread_exit`)
 - rust-lang#139608 (Clarify `async` block behaviour)
 - rust-lang#139847 (Delegate to inner `vec::IntoIter` from `env::ArgsOs`)
 - rust-lang#140159 (Avoid redundant WTF-8 checks in `PathBuf`)
 - rust-lang#140197 (Document breaking out of a named code block)
 - rust-lang#140389 (Remove `avx512dq` and `avx512vl` implication for `avx512fp16`)
 - rust-lang#140430 (Improve test coverage of HIR pretty printing.)
 - rust-lang#140507 (rustc_target: RISC-V: feature addition batch 3)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c3f500e into rust-lang:master May 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2025
@rust-timer
Unrolled build for rust-lang#139046
3417a4a 
Rollup merge of rust-lang#139046 - nnethercote:hir-Lifetime-better, r=lcnr

Improve `Lifetime::suggestion`

r? ``@lcnr``
@nnethercote nnethercote deleted the hir-Lifetime-better branch May 2, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shepmaster shepmaster shepmaster left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nnethercote @rust-log-analyzer @bors @lcnr @shepmaster @compiler-errors @rustbot