-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rustdoc UI test suite should more helpfully explain its run-time dependencies in errors, especially npm
#138134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
May 1, 2025
…-tool-error-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang#138134. It now looks like this:  cc `@kpreid`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
May 1, 2025
…-tool-error-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang#138134. It now looks like this:  cc ``@kpreid``
VlaDexa
added a commit
to VlaDexa/rust
that referenced
this issue
May 2, 2025
…-tool-error-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang#138134. It now looks like this:  cc `@kpreid`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2025
Rollup merge of rust-lang#140556 - GuillaumeGomez:improve-rustdoc-gui-tool-error-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang#138134. It now looks like this:  cc ``@kpreid``
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this issue
May 3, 2025
…or-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang/rust#138134. It now looks like this:  cc ``@kpreid``
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this issue
May 5, 2025
…or-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang/rust#138134. It now looks like this:  cc ``@kpreid``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Summary
I want to run the rustdoc tests, in preparation for tinkering with rustdoc.
rustdoc-gui-test
failed with a cryptic error:OptionMissing("npm")
. Also, in total, I had to install 3 things, and neither the error messages nor https://rustc-dev-guide.rust-lang.org/rustdoc.html told me what all those 3 things were, so I had to keep retrying.Command used
Expected behaviour
Tests pass or I get an explanation of what I need to change.
Actual behaviour
The first time I ran it, it failed but I got a helpful explanation:
So I installed nodejs and tried again, and I got this:
Evidently it means I should install
npm
, because when I did that, it got further, to yet another error:Then I did that, and it finally managed to run tests.
Bootstrap configuration (config.toml)
Operating system
macOS 15.3.1
HEAD
ac91805
Additional context
Build Log
@rustbot label -T-bootstrap +T-rustdoc +A-testsuite
The text was updated successfully, but these errors were encountered: