Tracking Issue for restructuring `std::sys` #117276

joboet · 2023-10-27T11:09:17Z

…sDenton Move platform modules into `sys::pal` This is the initial step of rust-lang#117276. `sys` just re-exports everything from the current `sys` for now, I'll move the implementations for the individual features one-by-one after this PR merges.

…isDenton Move personality implementation out of PAL The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.

Rollup merge of rust-lang#119935 - joboet:move_pal_personality, r=ChrisDenton Move personality implementation out of PAL The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.

Move OS String implementation into `sys` Part of rust-lang#117276. The new structure is really useful here, since we can easily eliminate a number of ugly `#[path]`-based imports. In the future, it might be good to move the WTF-8 implementation directly to the OS string implementation, I cannot see it being used anywhere else. That is a story for another PR, however.

Rollup merge of rust-lang#119996 - joboet:move_pal_os_str, r=ChrisDenton Move OS String implementation into `sys` Part of rust-lang#117276. The new structure is really useful here, since we can easily eliminate a number of ugly `#[path]`-based imports. In the future, it might be good to move the WTF-8 implementation directly to the OS string implementation, I cannot see it being used anywhere else. That is a story for another PR, however.

ChrisDenton · 2024-01-22T09:07:38Z

Something that just occurred to me is that we might want to add commits to https://github.com/rust-lang/rust/blob/master/.git-blame-ignore-revs if they're purely moving files. This allows GitHub's blame interface to ignore them.

Move cmath into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Move locks to `sys` Part of rust-lang#117276. r? `@ChrisDenton`

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=ChrisDenton Move thread local implementation to `sys` Part of rust-lang#117276.

As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

…lacrum std: move process implementations to `sys` As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

As per rust-lang#117276, this moves the platform definitions of `Stdout` and friends into `sys`. This PR also unifies the UNIX and Hermit implementations and moves the `__rust_print_err` function needed by libunwind on SGX into the dedicated module for such helper functions.

As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

…lacrum std: move process implementations to `sys` As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

Move the public `CommandEnvs` into the `process` module (and make it a wrapper type for an internal iterator type) and everything else into `sys::process` as per rust-lang#117276.

Move `fd` into `std::sys` Move platform definitions of `fd` into `std::sys`, as part of rust-lang#117276. Unlike other modules directly under `std::sys`, this is only available on some platforms and I have not provided a fallback abstraction for unsupported platforms. That is similar to how `std::os::fd` is gated to only supported platforms. Also, fix the `unsafe_op_in_unsafe_fn` lint, which was allowed for the Unix fd impl. Since macro expansions from `std::sys::pal::unix::weak` trigger this lint, fix it there too. cc `@joboet,` `@ChrisDenton`

As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

…lacrum std: move process implementations to `sys` As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

Move `fd` into `std::sys` Move platform definitions of `fd` into `std::sys`, as part of rust-lang#117276. Unlike other modules directly under `std::sys`, this is only available on some platforms and I have not provided a fallback abstraction for unsupported platforms. That is similar to how `std::os::fd` is gated to only supported platforms. Also, fix the `unsafe_op_in_unsafe_fn` lint, which was allowed for the Unix fd impl. Since macro expansions from `std::sys::pal::unix::weak` trigger this lint, fix it there too. cc `@joboet,` `@ChrisDenton` try-job: x86_64-gnu-aux

Rollup merge of rust-lang#139092 - thaliaarchi:move-fd-pal, r=joboet Move `fd` into `std::sys` Move platform definitions of `fd` into `std::sys`, as part of rust-lang#117276. Unlike other modules directly under `std::sys`, this is only available on some platforms and I have not provided a fallback abstraction for unsupported platforms. That is similar to how `std::os::fd` is gated to only supported platforms. Also, fix the `unsafe_op_in_unsafe_fn` lint, which was allowed for the Unix fd impl. Since macro expansions from `std::sys::pal::unix::weak` trigger this lint, fix it there too. cc `@joboet,` `@ChrisDenton` try-job: x86_64-gnu-aux

Move `fd` into `std::sys` Move platform definitions of `fd` into `std::sys`, as part of rust-lang#117276. Unlike other modules directly under `std::sys`, this is only available on some platforms and I have not provided a fallback abstraction for unsupported platforms. That is similar to how `std::os::fd` is gated to only supported platforms. Also, fix the `unsafe_op_in_unsafe_fn` lint, which was allowed for the Unix fd impl. Since macro expansions from `std::sys::pal::unix::weak` trigger this lint, fix it there too. cc `@joboet,` `@ChrisDenton` try-job: x86_64-gnu-aux

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc `@joboet`

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc ``@joboet``

Rollup merge of rust-lang#139710 - thaliaarchi:move-args-pal, r=joboet Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc ``@joboet``

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang/rust#117276. cc ``@joboet``

…=joboet Move `pal::env` into `std::sys::env_consts` Combine the `std::env::consts` platform implementations as a single file. Use the Unix file as the base, since it has 28 entries, and fold the 8 singleton platforms into it. The Unix file was roughly grouped into Linux, Apple, BSD, and everything else, roughly in alphabetical order. Alphabetically order them to make it easier to maintain and discard the Unix-specific groups to generalize it to all platforms. I'd prefer to have no fallback implementation, as I consider it a bug; however TEEOS, Trusty, and Xous have no definitions here. Since they otherwise have `pal` abstractions, that indicates that there are several platforms without `pal` abstractions which are also missing here. To support unsupported, create a little macro to handle the fallback case and not introduce ordering between the `cfg`s like `cfg_if!`. I've named the module `std::sys::env_consts`, because they are used in `std::env::consts` and I intend to use the name `std::sys::env` for the combination of `Args` and `Vars`. cc `@joboet` `@ChrisDenton` Tracked in rust-lang#117276.

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc ``@joboet``

…=joboet Move `pal::env` to `std::sys::env_consts` Combine the `std::env::consts` platform implementations as a single file. Use the Unix file as the base, since it has 28 entries, and fold the 8 singleton platforms into it. The Unix file was roughly grouped into Linux, Apple, BSD, and everything else, roughly in alphabetical order. Alphabetically order them to make it easier to maintain and discard the Unix-specific groups to generalize it to all platforms. I'd prefer to have no fallback implementation, as I consider it a bug; however TEEOS, Trusty, and Xous have no definitions here. Since they otherwise have `pal` abstractions, that indicates that there are several platforms without `pal` abstractions which are also missing here. To support unsupported, create a little macro to handle the fallback case and not introduce ordering between the `cfg`s like `cfg_if!`. I've named the module `std::sys::env_consts`, because they are used in `std::env::consts` and I intend to use the name `std::sys::env` for the combination of `Args` and `Vars`. cc `@joboet` `@ChrisDenton` Tracked in rust-lang#117276.

Rollup merge of rust-lang#139868 - thaliaarchi:move-env-consts-pal, r=joboet Move `pal::env` to `std::sys::env_consts` Combine the `std::env::consts` platform implementations as a single file. Use the Unix file as the base, since it has 28 entries, and fold the 8 singleton platforms into it. The Unix file was roughly grouped into Linux, Apple, BSD, and everything else, roughly in alphabetical order. Alphabetically order them to make it easier to maintain and discard the Unix-specific groups to generalize it to all platforms. I'd prefer to have no fallback implementation, as I consider it a bug; however TEEOS, Trusty, and Xous have no definitions here. Since they otherwise have `pal` abstractions, that indicates that there are several platforms without `pal` abstractions which are also missing here. To support unsupported, create a little macro to handle the fallback case and not introduce ordering between the `cfg`s like `cfg_if!`. I've named the module `std::sys::env_consts`, because they are used in `std::env::consts` and I intend to use the name `std::sys::env` for the combination of `Args` and `Vars`. cc `@joboet` `@ChrisDenton` Tracked in rust-lang#117276.

thaliaarchi · 2025-04-22T04:43:34Z

Some more to add to the list:

…=joboet Move `pal::env` to `std::sys::env_consts` Combine the `std::env::consts` platform implementations as a single file. Use the Unix file as the base, since it has 28 entries, and fold the 8 singleton platforms into it. The Unix file was roughly grouped into Linux, Apple, BSD, and everything else, roughly in alphabetical order. Alphabetically order them to make it easier to maintain and discard the Unix-specific groups to generalize it to all platforms. I'd prefer to have no fallback implementation, as I consider it a bug; however TEEOS, Trusty, and Xous have no definitions here. Since they otherwise have `pal` abstractions, that indicates that there are several platforms without `pal` abstractions which are also missing here. To support unsupported, create a little macro to handle the fallback case and not introduce ordering between the `cfg`s like `cfg_if!`. I've named the module `std::sys::env_consts`, because they are used in `std::env::consts` and I intend to use the name `std::sys::env` for the combination of `Args` and `Vars`. cc `@joboet` `@ChrisDenton` Tracked in rust-lang#117276.

joboet added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Oct 27, 2023

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 27, 2023

rustbot assigned joboet Oct 27, 2023

joboet mentioned this issue Oct 27, 2023

Move platform modules into sys::pal #117285

Merged

joboet mentioned this issue Nov 24, 2023

Move futex locks to sys_common #104329

Closed

joboet mentioned this issue Jan 13, 2024

Move personality implementation out of PAL #119935

Merged

This was referenced Jan 15, 2024

Move OS String implementation into sys #119996

Merged

Move cmath into sys #120109

Merged

rustbot added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jan 18, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2024

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton

dae6d2a

Move cmath into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2024

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton

42e1db5

Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 23, 2024

Unrolled build for rust-lang#120109

24e97e7

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

joboet mentioned this issue Feb 8, 2024

Move path implementations into sys #120776

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton

434f080

Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 9, 2024

Unrolled build for rust-lang#120776

27696f4

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

joboet mentioned this issue Feb 16, 2024

Move locks to sys #121177

Merged

bors added a commit to rust-lang-ci/rust that referenced this issue Feb 19, 2024

Auto merge of rust-lang#121177 - joboet:move_pal_locks, r=ChrisDenton

ccb1415

Move locks to `sys` Part of rust-lang#117276. r? `@ChrisDenton`

joboet mentioned this issue Feb 28, 2024

Move thread local implementation to sys #121758

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

9a213c6

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

26bac2a

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

2f72206

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 2, 2024

Unrolled build for rust-lang#121758

ea55f8c

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=ChrisDenton Move thread local implementation to `sys` Part of rust-lang#117276.

joboet mentioned this issue Mar 12, 2024

Tracking Issue for restructuring sys_common #84187

Closed

joboet mentioned this issue Mar 27, 2025

std: get rid of sys_common::process #139020

Open

thaliaarchi mentioned this issue Mar 29, 2025

Move fd into std::sys #139092

Merged

thaliaarchi mentioned this issue Apr 12, 2025

Move args into std::sys #139710

Merged

ChrisDenton added a commit to ChrisDenton/rust that referenced this issue Apr 13, 2025

Rollup merge of rust-lang#139710 - thaliaarchi:move-args-pal, r=joboet

a0a2ec3

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc `@joboet`

ChrisDenton added a commit to ChrisDenton/rust that referenced this issue Apr 13, 2025

Rollup merge of rust-lang#139710 - thaliaarchi:move-args-pal, r=joboet

daed9e2

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang#117276. cc ``@joboet``

thaliaarchi mentioned this issue Apr 15, 2025

Move pal::env to std::sys::env_consts #139868

Merged

github-actions bot pushed a commit to rust-lang/miri that referenced this issue Apr 17, 2025

Rollup merge of #139710 - thaliaarchi:move-args-pal, r=joboet

8617647

Move `args` into `std::sys` Move platform definitions of `args` into `std::sys`, as part of rust-lang/rust#117276. cc ``@joboet``

thaliaarchi mentioned this issue Apr 22, 2025

Move sys::pal::os::Env into sys::env #140143

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking Issue for restructuring `std::sys` #117276

Tracking Issue for restructuring `std::sys` #117276

joboet commented Oct 27, 2023 •

edited

Loading

ChrisDenton commented Jan 22, 2024

thaliaarchi commented Apr 22, 2025

Tracking Issue for restructuring std::sys #117276

Tracking Issue for restructuring std::sys #117276

Comments

joboet commented Oct 27, 2023 • edited Loading

ChrisDenton commented Jan 22, 2024

thaliaarchi commented Apr 22, 2025

Tracking Issue for restructuring `std::sys` #117276

Tracking Issue for restructuring `std::sys` #117276

joboet commented Oct 27, 2023 •

edited

Loading