Skip to content

Do not use gen as a variable name #13628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Do not use gen as a variable name #13628

merged 1 commit into from
Oct 31, 2024

Conversation

samueltardieu
Copy link
Contributor

gen will be a reserved word in Rust 2024.

changelog: none

@samueltardieu
Do not use gen as a variable name
a304709 
`gen` will be a reserved word in Rust 2024.
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
@samueltardieu samueltardieu mentioned this pull request Oct 30, 2024
Closed
4 tasks
@xFrednet
Copy link
Member

LGTM, thanks!

Gen a poem,
to approve this art,
Roses are red,
Violets are blue,
For lines for approval,
are full now,
and a seventh
and eighth as well

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit a304709 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Testing commit a304709 with merge 2298a67...

@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 2298a67 to master...

@bors bors merged commit 2298a67 into rust-lang:master Oct 31, 2024
8 checks passed
@samueltardieu samueltardieu deleted the push-puluprmsyuzq branch November 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samueltardieu @rustbot @xFrednet @bors