Skip to content

Remove duplicate constant definitions for AIX #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

xingxue-ibm
Copy link
Contributor

Description

Remove duplicate constant definitions in src/unix/aix/mod.rs, which is exposed by commit a541bf4.

c_enum! {
   #[repr(u32)]
    pub enum ACTION {
        FIND = 0,
        ENTER,
    }
}
...
// search.h
pub const FIND: c_int = 0;
pub const ENTER: c_int = 1;

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 28, 2025
@tgross35 tgross35 added this pull request to the merge queue Jul 28, 2025
Merged via the queue into rust-lang:main with commit bdc4b7d Jul 28, 2025
48 of 52 checks passed
@tgross35
Copy link
Contributor

Just an FYI, your GH account doesn't seem to be linked to your commit email. E.g. https://github.com/rust-lang/libc/commit/bdc4b7df37ec8bbac325ddd6cdba712a0abe3bcd.patch is authored by you, but bdc4b7d doesn't link to your user.

Not a problem of course, just letting you know in case you want to update it :)

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
@xingxue-ibm
Copy link
Contributor Author

xingxue-ibm commented Jul 29, 2025

Just an FYI, your GH account doesn't seem to be linked to your commit email. E.g. https://github.com/rust-lang/libc/commit/bdc4b7df37ec8bbac325ddd6cdba712a0abe3bcd.patch is authored by you, but bdc4b7d doesn't link to your user.

Not a problem of course, just letting you know in case you want to update it :)

Thanks for letting me know, fixed it! I was accidentally using the same Git config for both internal and external repositories. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants