Don't allow improper_ctypes
#4584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
no-allow-improper-ctypes
branch
from
79334fc to
86898eb
Compare
tgross35
force-pushed
the
no-allow-improper-ctypes
branch
from
86898eb to
b2a9785
Compare
tgross35
force-pushed
the
no-allow-improper-ctypes
branch
2 times, most recently
from
49c0f9a to
a0c88fc
Compare
Resolve the `improper_ctypes` warning on l4re-uclibc that we are getting in CI. The current version was added in e412497 ("Move L4Re-specific code into separate module.") and doesn't seem to have been intentional.
Most of what this crate does is interact with C, so the lint should be useful. It can be disabled on a case-by-case basis as needed. There are a few fixes needed for enums, which will be going away anyway (rust-lang#4419). Additionally, switch the `bad_style` lint to the newer name `nonstandard_style`.
tgross35
force-pushed
the
no-allow-improper-ctypes
branch
from
a0c88fc to
8fa09ee
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
Resolve the `improper_ctypes` warning on l4re-uclibc that we are getting in CI. The current version was added in e412497 ("Move L4Re-specific code into separate module.") and doesn't seem to have been intentional. (backport <rust-lang#4584>) (cherry picked from commit 95c1400)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
Most of what this crate does is interact with C, so the lint should be useful. It can be disabled on a case-by-case basis as needed. There are a few fixes needed for enums, which will be going away anyway (rust-lang#4419). Additionally, switch the `bad_style` lint to the newer name `nonstandard_style`. (backport <rust-lang#4584>) (cherry picked from commit 38bb46e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of what this crate does is interact with C, so the lint should be useful. It can be disabled on a case-by-case basis as needed.
Additionally, switch the
bad_stylelint to the newer namenonstandard_style.