Add a couple of examples on the generator section of the book #697
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
requested changes
Mar 27, 2021
| @@ -34,6 +34,18 @@ Of these types, only upvars and resume/yield/return are stored directly in `Gene | |||
| the generator by virtue of sharing the same `GeneratorId`. It is only used when determining | |||
| auto trait impls, where it is considered a 'constituent type'. | |||
|
|
|||
| For example: | |||
|
|
|||
| ```rust | |||
There was a problem hiding this comment.
Also, probably make a comment that this isn't a "real" syntax at the moment.
|
|
||
| ```rust | ||
| fn gen() -> Bar { | ||
| let a = yield 0; |
There was a problem hiding this comment.
For clarity, let's make this 0usize.
| ```rust | ||
| fn gen() -> Bar { | ||
| let a = yield 0; | ||
| return use(a); |
There was a problem hiding this comment.
maybe add a fn use(_: usize) -> Bar {} for clarity
|
r=me on changes and green CI @bors delegate+ |
|
✌️ @spastorino can now approve this pull request |
|
(I also just realized that @spastorino already has r+ rights) |
spastorino
force-pushed
the
add-examples-about-generators
branch
from
d0f2186 to
255db5a
Compare
|
@bors r=jackh726 |
|
📌 Commit 255db5a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples may be wrong or probably could be made better but I guess having some examples here would to better understand these concepts.