add Movability to Generator #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
approved these changes
Feb 10, 2021
basil-cow
force-pushed
the
generator_movability
branch
from
9243876 to
cef3c78
Compare
jackh726
reviewed
Feb 11, 2021
| @@ -44,7 +44,7 @@ Some common examples of auto traits are `Send` and `Sync`. | |||
| | slices | ⚬ | ⚬ | ⚬ | ✅ | ⚬ | ⚬ | ⚬ | ⚬ | ⚬ | ✅ | | |||
| | arrays | ✅ | ✅ | ✅ | ❌ | ⚬ | ⚬ | ⚬ | ⚬ | ⚬ | ✅ | | |||
| | closures | ✅ | ✅ | ✅ | ⚬ | ⚬ | ⚬ | ✅ | ⚬ | ⚬ | ✅ | | |||
| | generators | ⚬ | ⚬ | ❌ | ⚬ | ⚬ | ⚬ | ⚬ | ❌ | ❌ | ❌ | | |||
| | generators | ⚬ | ⚬ | ❌ | ⚬ | ⚬ | ⚬ | ⚬ | ✅ | ❌ | ❌ | | |||
There was a problem hiding this comment.
Doesn't this also implement auto trait handling for generators?
There was a problem hiding this comment.
It was already implemented but I guess it's complete now
basil-cow
force-pushed
the
generator_movability
branch
from
cef3c78 to
0b8e2be
Compare
|
@bors r+ |
|
📌 Commit 0b8e2be has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pretty straightforward
closes #618
cc #363