Skip to content

Create single Github actions job to gate bors on #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

nathanwhit
Copy link
Member

This is a preliminary step for getting bors integrated into the chalk repo.

@jackh726
Copy link
Member

Hmm. So how will this work will mdbook-linkcheck? I kind of feel like we shouldn't gate anything on it. Also, seems like it generates to separate checks (maybe one for stable and one for nightly test)

@nathanwhit
Copy link
Member Author

nathanwhit commented Jul 23, 2020

Hmm. So how will this work will mdbook-linkcheck? I kind of feel like we shouldn't gate anything on it. Also, seems like it generates to separate checks (maybe one for stable and one for nightly test)

Makes sense to not gate on linkcheck, so I updated the workflow to reflect that.

As for the two checks (which was adopted from here as suggested by pietroalbini) it's actually intentional. As far as I know it's due to limitations in GHA, which make it so that you need to have two separate (and mutually exclusive) checks to accomplish what we need –– one check that just returns 0 if all other checks passed, and another that just returns 1 if any other check fails.

@jackh726
Copy link
Member

Oh, duh. Right. Um, do they have to be named "bors build finished" or could they be "bors build finished success" and "bors build finished failed" to make them more clear

@nathanwhit
Copy link
Member Author

As far as I know, I think they do need to have the same name (unfortunately).

@jackh726 jackh726 merged commit 239f10f into rust-lang:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants