complete wf checks for Copy impls #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 9, 2020
jackh726
requested changes
Jun 10, 2020
| | TypeName::Ref(Mutability::Not) | ||
| | TypeName::Never => return None, | ||
| TypeName::Adt(adt_id) => (*adt_id, substitution), | ||
| _ => return Some(GoalData::CannotProve(()).intern(interner)), |
There was a problem hiding this comment.
Mmm, can we list each one separately? So when we add a new builtin type, we make sure it's covered.
There was a problem hiding this comment.
That's the whole list, there are no more types for which Copy impls are allowed
nikomatsakis
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ask me why the branch name is const, I don't know